Why Security Defects Go Unnoticed during Code Reviews? A Case-Control Study of the Chromium OS Project

TL;DR

This study analyzes factors influencing the effectiveness of code reviews in detecting security vulnerabilities in the Chromium OS project, identifying key attributes that differentiate successful from missed security defect detections.

Contribution

It introduces a data-driven analysis with a logistic regression model revealing nine review attributes impacting security defect detection effectiveness.

Findings

Time to complete review positively impacts vulnerability detection.

Number of mutual reviews between developers improves detection.

Reviewing for bug fixes increases likelihood of identifying security defects.

Abstract

Peer code review has been found to be effective in identifying security vulnerabilities. However, despite practicing mandatory code reviews, many Open Source Software (OSS) projects still encounter a large number of post-release security vulnerabilities, as some security defects escape those. Therefore, a project manager may wonder if there was any weakness or inconsistency during a code review that missed a security vulnerability. Answers to this question may help a manager pinpointing areas of concern and taking measures to improve the effectiveness of his/her project's code reviews in identifying security defects. Therefore, this study aims to identify the factors that differentiate code reviews that successfully identified security defects from those that missed such defects. With this goal, we conduct a case-control study of Chromium OS project. Using multi-stage semi-automated approaches, we build a dataset of 516 code reviews that successfully identified security defects and 374 code reviews where security defects escaped. The results of our empirical study suggest that the are significant differences between the categories of security defects that are identified and that are missed during code reviews. A logistic regression model fitted on our dataset achieved an AUC score of 0.91 and has identified nine code review attributes that influence identifications of security defects. While time to complete a review, the number of mutual reviews between two developers, and if the review is for a bug fix have positive impacts on vulnerability identification, opposite effects are observed from the number of directories under review, the number of total reviews by a developer, and the total number of prior commits for the file under review.